[FrameworkBundle][HttpKernel][MonologBridge] Revisit wiring of debug loggers #51284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2023
stof
reviewed
Aug 22, 2023
| @@ -32,7 +37,7 @@ public function process(ContainerBuilder $container): void | |||
|
|
|||
| public static function configureLogger(Logger $logger): void | |||
| { | |||
| if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg'], true) && method_exists($logger, 'enableDebug')) { | |||
There was a problem hiding this comment.
because the method is always available per composer constraints nowadays
nicolas-grekas
added a commit
that referenced
this pull request
Aug 23, 2023
…oggerConfigurator (nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [HttpKernel] Fix checking for the runtime mode in DebugLoggerConfigurator | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Fixing #51284, my bad. Eating your own dog food works :) Commits ------- 1836a1e [HttpKernel] Fix checking for the runtime mode in DebugLoggerConfigurator
This was referenced Sep 28, 2023
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #51229
Implements the suggestions from @stof and @Seldaek in #51229 (comment)
It turns our we had almost everything available. This is mostly a matter of wiring.
Symfony\Bridge\Monolog\LoggerAddDebugLogProcessorPass::configureLogger()DebugLoggerConfiguratorto HttpKernel, which wiresDebugProcessorwhen desiredBonus:
$debugto HttpKernel'sLoggerEnableLoggerDebugModePassin favor of the previous