8000 [Cache] harden LockRegistry tests, consider PHP files only by xabbuh · Pull Request #51278 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] harden LockRegistry tests, consider PHP files only #51278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2023
Merged

[Cache] harden LockRegistry tests, consider PHP files only #51278

merged 1 commit into from
Aug 5, 2023

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Aug 5, 2023 •
edited
Loading
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

see https://github.com/symfony/symfony/actions/runs/5761767836/job/15641917703#step:8:2977

@carsonbot carsonbot added this to the 5.4 milestone Aug 5, 2023
@nicolas-grekas
Copy link
Member

let's update the .github/expected file instead, it's a sign that it's out of sync ;)

@xabbuh
Copy link
Member Author
xabbuh commented Aug 5, 2023

I am not sure which file you want to update, but the difference here I guess is coming from backup files being created in the pipeline. Locally the test already passes without the changes.

nicolas-grekas
nicolas-grekas approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean .github/expected-missing-return-types.diff on 6.4: the .orig files are created by the patch command when adding return types in the CI. Not sure why this issue pops up recently.

Anyway, 👍 for this change!

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit c43dcc6 into symfony:5.4 Aug 5, 2023
@xabbuh xabbuh deleted the cache-hardening-tests branch August 5, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
41C2 5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot
0