handle inheritance in config:dump-reference #5126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $extension = $bundle->getContainerExtension(); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
why not simply the following ?
<?php
$bundles = $kernel->getBundles()
$bundle = $bundles[$name]; // checking for invalid names here is let to the reader
$extension = $bundle->getContainerExtension();There was a problem hiding this comment.
you are right .. i thought this way would be faster .. but since the bundles array already exists .. it was infact quite a bit slower. correct it ..
…sed to the command
fabpot
added a commit
that referenced
this pull request
Aug 6, 2012
…#5126) Commits ------- cdfbe72 handle inheritance in config:dump-reference when a bundle name is passed to the command Discussion ---------- handle inheritance in config:dump-reference Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: ? Fixes the following tickets: - License of the code: MIT Currently when passing in a bundle name that identifies a bundle that is a parent to another bundle, it will not return the reference for the requested bundle, but for the inheriting (even if that bundle has no configuration class). F.e. app/console config:dump-reference SymfonyCmfBlockBundle will fail if there is a Bundle SandboxBlockBundle that has SymfonyCmfBlockBundle set as the parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: ?
Fixes the following tickets: -
License of the code: MIT
Currently when passing in a bundle name that identifies a bundle that is a parent to another bundle, it will not return the reference for the requested bundle, but for the inheriting (even if that bundle has no configuration class).
F.e.
app/console config:dump-reference SymfonyCmfBlockBundle
will fail if there is a Bundle SandboxBlockBundle that has SymfonyCmfBlockBundle set as the parent.