8000 [Workflow] Add a `TraceableWorkflow` by lyrixx · Pull Request #51220 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Workflow] Add a TraceableWorkflow #51220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

[Workflow] Add a TraceableWorkflow #51220

merged 1 commit into from
Oct 20, 2023

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Aug 1, 2023
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

image

image

Initially, I wanted to display the current marking on the graph, but it's not possible. "current" does not mean anything. What if I use the workflow for 2 entities? What if I call twice apply(). Which marking should I choose? => this is not possible.

But, DoctrineBundle use ajax, like for explaining SQL request. It would be nice to be able to click on a marking, and it'll re-render the graph with this marking. WDYT?

@carsonbot carsonbot added this to the 6.4 milestone Aug 1, 2023
@OskarStark OskarStark changed the title [Worflow] Add a TraceableWorkflow [Worflow] Add a TraceableWorkflow Aug 2, 2023
@lyrixx lyrixx force-pushed the workflow-traceable branch from b8e51a2 to ae24365 Compare August 2, 2023 09:32
@lyrixx lyrixx force-pushed the workflow-traceable branch from ae24365 to 6aa12ed Compare August 8, 2023 14:38
@carsonbot carsonbot changed the title [Worflow] Add a TraceableWorkflow [Workflow] [Worflow] Add a TraceableWorkflow Sep 11, 2023
@lyrixx
Copy link
Member Author
lyrixx commented Oct 10, 2023

This PR is ready for 2 month. I'm gonna merge it by the end of the week if there are not more review

@fabpot fabpot changed the title [Workflow] [Worflow] Add a TraceableWorkflow [Workflow] Add a TraceableWorkflow Oct 10, 2023
@fabpot
Copy link
Member
fabpot commented Oct 18, 2023

@lyrixx Last call for 6.4 :)

@lyrixx lyrixx force-pushed the workflow-traceable branch 2 times, most recently from 0c7dc40 to 750aa14 Compare October 19, 2023 09:08
@lyrixx
Copy link
Member Author
lyrixx commented Oct 19, 2023

Hello @fabpot, @stof and others reviewer.

I addressed your comments, I think the PR is ready 👍🏼

@lyrixx lyrixx force-pushed the workflow-traceable branch 4 times, most recently from 2d5a6ee to d75ea2f Compare October 19, 2023 09:27
@lyrixx lyrixx force-pushed the workflow-traceable branch from d75ea2f to 023078b Compare October 19, 2023 10:28
@lyrixx lyrixx requested a review from nicolas-grekas October 19, 2023 15:36
@lyrixx lyrixx force-pushed the workflow-traceable branch from 023078b to 963cc7a Compare October 19, 2023 15:38
@fabpot
Copy link
Member
fabpot commented Oct 20, 2023

Thank you @lyrixx.

@fabpot fabpot mentioned this pull request Oct 20, 2023
Closed
@fabpot fabpot merged commit 124706b into symfony:6.4 Oct 20, 2023
@lyrixx lyrixx deleted the workflow-traceable branch October 20, 2023 08:46
This was referenced Oct 21, 2023
Merged
Merged
@derrabus derrabus mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@HeahDude HeahDude HeahDude left review comments

@fabpot fabpot fabpot approved these changes

@94noni 94noni 94noni approved these changes

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Feature Status: Reviewed Workflow
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@lyrixx @fabpot @stof @94noni @HeahDude @carsonbot
0