[Translation] Add --as-tree option to translation:pull command
#51153
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
There was a problem hiding this comment.
Lovely. Well done.
I like that you added tests for this feature.
I had a few comments that I would like your help addressing.
src/Symfony/Component/Translation/Command/TranslationPullCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Command/TranslationPullCommand.php
Outdated
Show resolved
Hide resolved
--as-tree option to translation:pull command
There was a problem hiding this comment.
Little comment on the changelog, otherwise it's ok for me 👍. Thanks for your contribution
|
Thank you @syffer. |
This PR adds an option
--as-treeto the commandtranslation:pull, like the PR #38393 did it for the commandtranslation:extract.This option would ease the use of the command
translation:pullwhen the yaml translations are stored as a tree. Without it, the yaml translations are inlined after atranslation:pull, regardless of whether it was stored as inline or as a tree. To bypass this, you would either have totranslation:pulltranslation.dumper.yaml) to forcefully add the optionas_treefor the yaml file dumper