8000 [5.4] Fix symfony/deprecation-contracts require by fancyweb · Pull Request #51151 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[5.4] Fix symfony/deprecation-contracts require #51151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

[5.4] Fix symfony/deprecation-contracts require #51151

merged 1 commit into from
Jul 30, 2023

Conversation

fancyweb
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Require symfony/deprecation-contracts in package that use trigger_deprecation without requiring the dependency 🙈 .

@carsonbot carsonbot added this to the 5.4 milestone Jul 28, 2023
@fancyweb fancyweb changed the title Fix symfony/deprecation-contracts require [5.4] Fix symfony/deprecation-contracts require Jul 28, 2023
@fancyweb fancyweb marked this pull request as draft July 28, 2023 15:15
@fancyweb fancyweb marked this pull request as ready for review July 28, 2023 15:20
@fancyweb
Copy link
Contributor Author
fancyweb commented Jul 28, 2023 •
edited
Loading

All branches are impacted so I'll fix them one by one after each one is ok and merged up?

@derrabus
Copy link
Member

I think we should drop this change when merging up. All deprecations have been resolved in 6.0, so we need to re-evaluate this topic on 6.2 anyway.

@fancyweb
Copy link
Contributor Author

I agree, I already prepared all PRs and it's easier to just drop the changes when merging up since each maintained branch is a little different 😅

@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 3034e8e into symfony:5.4 Jul 30, 2023
@fancyweb fancyweb deleted the fix-deprec-req-54 branch July 31, 2023 07:02
@fancyweb fancyweb mentioned this pull request Jul 31, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Jul 31, 2023
@nicolas-grekas
minor #51174 [6.3] Fix symfony/deprecation-contracts require (fancyweb)
07d96ed 
This PR was merged into the 6.3 branch.

Discussion
----------

[6.3] Fix symfony/deprecation-contracts require

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follow-up to #51151

Commits
-------

7b168bb Fix symfony/deprecation-contracts require
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @derrabus @nicolas-grekas @carsonbot
0