8000 [Scheduler] make `ScheduledStamp` "send-able" by kbond · Pull Request #51092 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Scheduler] make ScheduledStamp "send-able" #51092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

[Scheduler] make ScheduledStamp "send-able" #51092

merged 1 commit into from
Aug 1, 2023

Conversation

kbond
Copy link
Member
@kbond kbond commented Jul 24, 2023 •
edited
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

It's important the ScheduledStamp stay on the envelope when using RedispatchMessage (https://speakerdeck.com/fabpot/s?slide=46).

This may still need some work as at least one of the triggers (CallbackTrigger) cannot be serialized. Any ideas about this?

@carsonbot carsonbot added Status: Needs Review Feature RFC RFC = Request For Comments (proposals about features that you want to be discussed) Scheduler labels Jul 24, 2023
@carsonbot carsonbot added this to the 6.4 milestone Jul 24, 2023
@carsonbot carsonbot changed the title [RFC][Scheduler] make ScheduledStamp "send-able" [Scheduler] make ScheduledStamp "send-able" Jul 24, 2023
@kbond kbond force-pushed the scheduler-send-stamp branch from e8da2b4 to d13d3ec Compare July 24, 2023 20:02
@fabpot fabpot force-pushed the scheduler-send-stamp branch from d13d3ec to 8efa5fc Compare August 1, 2023 07:33
@fabpot
Copy link
Member
fabpot commented Aug 1, 2023

Thank you @kbond.

@fabpot fabpot merged commit d660091 into symfony:6.4 Aug 1, 2023
@fabpot fabpot mentioned this pull request Aug 1, 2023
Closed
@kbond kbond deleted the scheduler-send-stamp branch August 1, 2023 12:56
@kbond kbond mentioned this pull request Aug 1, 2023
Closed
This was referenced Oct 21, 2023
Merged
Merged
@petrisorciprian-vitals petrisorciprian-vitals mentioned this pull request Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature RFC RFC = Request For Comments (proposals about features that you want to be discussed) Scheduler Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@kbond @fabpot @carsonbot
0