8000 [MonologBridge] Remove support for monolog < 3.0 by lyrixx · Pull Request #51091 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[MonologBridge] Remove support for monolog < 3.0 #51091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

[MonologBridge] Remove support for monolog < 3.0 #51091

merged 1 commit into from
Jul 28, 2023

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Jul 24, 2023 •
edited
Loading
Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

cc @Seldaek

@carsonbot carsonbot added this to the 7.0 milestone Jul 24, 2023
@lyrixx lyrixx force-pushed the monolog-3 branch 2 times, most recently from 1ecbc0b to 67dd5a3 Compare July 25, 2023 07:46
@lyrixx lyrixx requested a review from nicolas-grekas July 25, 2023 08:07
nicolas-grekas
nicolas-grekas reviewed Jul 25, 2023
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this, here are some minor comments

Seldaek
Seldaek reviewed Jul 25, 2023
View reviewed changes
src/Symfony/Bridge/Monolog/Handler/NotifierHandler.php
}

$notification->importanceFromLogLevelName(Logger::getLevelName($record['level']));
$notification->importanceFromLogLevelName($record->level->getName());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to me like a psalm bug, if it cannot determine that a const array of strings is of type string[].

@derrabus derrabus changed the title [MonologBridge] Remove support for monolog < 3 [MonologBridge] Remove support for monolog < 3.0 Jul 27, 2023
nicolas-grekas
nicolas-grekas reviewed Jul 28, 2023
View reviewed changes
@lyrixx lyrixx force-pushed the monolog-3 branch 2 times, most recently from 59f5f15 to c086746 Compare July 28, 2023 08:09
@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit e76095e into symfony:7.0 Jul 28, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 28, 2023
Closed
@lyrixx lyrixx deleted the monolog-3 branch July 28, 2023 08:29
@derrabus derrabus mentioned this pull request Aug 4, 2023
Merged
fabpot added a commit that referenced this pull request Aug 4, 2023
@fabpot
minor #51266 [MonologBridge] Remove Monolog 1 compat from FirePHPHand…
ae04717 
…lerTest (derrabus)

This PR was merged into the 7.0 branch.

Discussion
----------

[MonologBridge] Remove Monolog 1 compat from FirePHPHandlerTest

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Follows #51091
| License       | MIT
| Doc PR        | N/A

Commits
-------

9ebdc3d [MonologBridge] Remove more Monolog 1 compat from FirePHPHandlerTest
@vtsykun vtsykun mentioned this pull request Oct 1, 2023
Merged
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Nov 21, 2023
@nicolas-grekas
bug #51797 [MonologBridge] Fix error cannot use object of type as arr…
c9ac1b9 
…ay (vtsykun)

This PR was merged into the 7.0 branch.

Discussion
----------

[MonologBridge] Fix error cannot use object of type as array

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | yes
| New feature?  | -
| Deprecations? |  -
| Tickets       | -
| License       | MIT

Bug was introduced in #51091

```
  "e" => Error {
    #message: "Cannot use object of type Symfony\Component\Lock\Key as array"
    #code: 0
    #file: "./excluded/symfony/src/Symfony/Bridge/Monolog/Formatter/ConsoleFormatter.php"
    #line: 191
    -previous: Error {
      #message: "Cannot use object of type Symfony\Component\Lock\Key as array"
      #code: 0
      #file: "./excluded/symfony/src/Symfony/Bridge/Monolog/Formatter/ConsoleFormatter.php"
      #line: 191
      trace: {
        ./excluded/symfony/src/Symfony/Bridge/Monolog/Formatter/ConsoleFormatter.php:191 {
          Symfony\Bridge\Monolog\Formatter\ConsoleFormatter->dumpData(mixed $data, bool $colors = null): string^
          ›
          › if (($data['data'] ?? null) instanceof Data) {
          ›     $data = $data['data'];
        }
        ./excluded/symfony/src/Symfony/Bridge/Monolog/Formatter/ConsoleFormatter.php:171 { …}
        ./excluded/symfony/src/Symfony/Bridge/Monolog/Formatter/ConsoleFormatter.php:101 { …}
        ./vendor/monolog/monolog/src/Monolog/Handler/AbstractProcessingHandler.php:42 { …}
        ./excluded/symfony/src/Symfony/Bridge/Monolog/Handler/ConsoleHandler.php:85 { …}
        ./vendor/monolog/monolog/src/Monolog/Logger.php:379 { …}
        ./vendor/monolog/monolog/src/Monolog/Logger.php:580 { …}
        ./excluded/symfony/src/Symfony/Component/Lock/Lock.php:89 { …}
```

Commits
-------

ec0df6d Fix error cannot use object of type as array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seldaek Seldaek Seldaek left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@derrabus derrabus derrabus left review comments

Assignees
No one assigned
Labels
MonologBridge Status: Needs Review
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lyrixx @nicolas-grekas @Seldaek @derrabus @carsonbot
0