8000 Fix bug MapQueryString when request has only optional parameters by dddenisov · Pull Request #51062 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix bug MapQueryString when request has only optional parameters #51062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix bug MapQueryString when request has only optional parameters #51062

wants to merge 1 commit into from

Conversation

dddenisov
Copy link
@dddenisov dddenisov commented Jul 21, 2023 •
edited
Loading
Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50690
License MIT
Doc PR

Based on the discussion here #50690 I propose my solution

@carsonbot carsonbot added this to the 6.4 milestone Jul 21, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for features / 5.4, 6.2, or 6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Closing as this can't be the solution we're looking for (and because we don't even agree on the problem :) )
Thanks for proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[HttpKernel] #[MapQueryString] with an empty query string always returns null
3 participants
@dddenisov @carsonbot @nicolas-grekas
0