8000 [Validator] Fix constraints merge for protected and public properties by kontsevoye · Pull Request #51027 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Fix constraints merge for protected and public properties #51027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Validator] Fix constraints merge for protected and public properties #51027

wants to merge 1 commit into from

Conversation

kontsevoye
Copy link
@kontsevoye kontsevoye commented Jul 19, 2023 •
edited
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

There was backward compatibility break in symfony/validator@81772c1.

When you have a parent class with a public or protected property that has a constraint, and a child class that also has a constraint for the same property, you need to merge them rather than override them.

@carsonbot carsonbot added this to the 5.4 milestone Jul 19, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@kontsevoye kontsevoye mentioned this pull request Jul 19, 2023
Closed
@xabbuh
Copy link
Member
xabbuh commented Jul 20, 2023

This looks like a duplicate of #50788 to me.

@kontsevoye
Copy link
Author

Yes, you're right. So, I'm going to close this PR

@kontsevoye kontsevoye closed this Jul 20, 2023
@kontsevoye kontsevoye deleted the validator-metadata-patch branch July 20, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@kontsevoye @carsonbot @xabbuh
0