10000 [VarDumper] Fix dumping `ArrayObject` with `DumpDataCollector` by HypeMC · Pull Request #50960 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] Fix dumping ArrayObject with DumpDataCollector #50960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2023
Merged

[VarDumper] Fix dumping ArrayObject with DumpDataCollector #50960

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2c6f7
[VarDumper] Add tests to demonstrate a bug when dumping ArrayObject w…
lyrixx Jul 11, 2023
b25f377
[VarDumper] Fix dumping `ArrayObject` with `DumpDataCollector`
HypeMC Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[VarDumper] Add tests 10000 to demonstrate a bug when dumping ArrayObject w… 
…ith full stack fmk
  • Loading branch information
@lyrixx @HypeMC
lyrixx authored and HypeMC committed Jul 12, 2023
commit 1f2c6f76df7d9cd386378696bafcc6a51445550a
43 changes: 43 additions & 0 deletions src/Symfony/Component/VarDumper/Tests/Integration/dump_data_collector.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
--TEST--
Test integration with Symfony's DumpDataCollector
--FILE--
<?php
putenv('NO_COLOR=1');

$vendor = __DIR__;
while (!file_exists($vendor.'/vendor')) {
$vendor = \dirname($vendor);
}
require $vendor.'/vendor/autoload.php';

use Symfony\Component\HttpKernel\DataCollector\DumpDataCollector;
use Symfony\Component\VarDumper\Cloner\VarCloner;
use Symfony\Component\VarDumper\Dumper\CliDumper;
use Symfony\Component\VarDumper\VarDumper;

VarDumper::setHandler(function ($var, string $label = null) {
$dumper = new DumpDataCollector();
$cloner = new VarCloner();
$handler = function ($var, string $label = null) use ($dumper, $cloner) {
$var = $cloner->cloneVar($var);
if (null !== $label) {
$var = $var->withContext(['label' => $label]);
}

$dumper->dump($var);
};
VarDumper::setHandler($handler);
$handler($var, $label);
});

$schemas = new \ArrayObject();
dump($schemas);
$schemas['X'] = new \ArrayObject(['type' => 'object']);

--EXPECTF--
ArrayObject {#%d
-storage: []
flag::STD_PROP_LIST: false
flag::ARRAY_AS_PROPS: false
iteratorClass: "ArrayIterator"
}
43 changes: 43 additions & 0 deletions src/Symfony/Component/VarDumper/Tests/Integration/dump_data_collector2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
--TEST--
Test integration with Symfony's DumpDataCollector
--FILE--
<?php
putenv('NO_COLOR=1');

$vendor = __DIR__;
while (!file_exists($vendor.'/vendor')) {
$vendor = \dirname($vendor);
}
require $vendor.'/vendor/autoload.php';

use Symfony\Component\HttpKernel\DataCollector\DumpDataCollector;
use Symfony\Component\VarDumper\Cloner\VarCloner;
use Symfony\Component\VarDumper\Dumper\CliDumper;
use Symfony\Component\VarDumper\VarDumper;

VarDumper::setHandler(function ($var, string $label = null) {
$dumper = new DumpDataCollector();
$cloner = new VarCloner();
$handler = function ($var, string $label = null) use ($dumper, $cloner) {
$var = $cloner->cloneVar($var);
if (null !== $label) {
$var = $var->withContext(['label' => $label]);
}

$dumper->dump($var);
};
VarDumper::setHandler($handler);
$handler($var, $label);
});

$schemas = new \ArrayObject();
dump($schemas);
$schemas['X'] = 'A';

--EXPECTF--
ArrayObject {#%d
-storage: []
flag::STD_PROP_LIST: false
flag::ARRAY_AS_PROPS: false
iteratorClass: "ArrayIterator"
}
0