[Form] Deprecate not configuring the default_protocol option of the UrlType
#50922
Conversation
|
IIRC we overrode the tests in other cases. But we should add a comment that the overridden methods can be removed in the |
|
Thanks @xabbuh, hope I did it correctly |
src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php
Outdated
Show resolved
Hide resolved
cb28233 to
a2eac76
Compare
a2eac76 to
81a5079
Compare
81a5079 to
77802f8
Compare
|
Is it still time to merge this in 6.4 or will I have to rebase on 7.1 when the branch will be created? |
|
we should have a test ensuring that passing |
src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php
Outdated
Show resolved
Hide resolved
|
@stof thanks for the review 🙏 Do you know how I can test whether a given code does not trigger a deprecation? |
|
@MatTheCat Don't put the |
|
You should add a test that runs into the situation, and if it triggers a deprecation, the CI will fail. |
src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Validator/Type/UrlTypeValidatorExtensionTest.php
Outdated
Show resolved
Hide resolved
16bcc43 to
286bab1
Compare
286bab1 to
3ce498d
Compare
|
Thank you @MatTheCat. |
…col` (alexislefebvre) This PR was submitted for the 5.4 branch but it was merged into the 6.4 branch instead. Discussion ---------- [Form] URLType : explain `null` value for 9314 `default_protocol` Sources: - symfony/symfony#30635 - symfony/symfony#50922 Commits ------- 0b521e7 URLType: explain `null` value for `default_protocol`
You would expect an
<input type="url">from theUrlType, but it is not possible as long asdefault_protocolhas a value, because then you have to accept inputs that are not URLs (and you get an<input type="text" inputmode="url">).In order to change
default_protocolfrom'http'tonullin 8.0, we must first deprecate not configuring it.