[ExpressionLanguage] Remove deprecated code paths #50867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc3126a to
6bb914d
Compare
6bb914d to
7050bc8
Compare
|
Thank you @alexandre-daubois. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 4, 2023
…ng strict comparison (alexandre-daubois) This PR was merged into the 7.0 branch. Discussion ---------- [ExpressionLanguage] `in` and `not in` operators are using strict comparison Related to symfony/symfony#50867 Commits ------- ba5059e [ExpressionLanguage] `in` and `not in` operators are using strict comparison
Merged
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Jan 6, 2024
Symfony 7 removed deprecated code paths [1][2] and therefore started using strict `in_array()` check for the `in` and `notIn` condition in the expression language. With #102746 the usage of symfony 7 has been allowed, which itself introduces breaking changes. It is optional to upgrade to symfony 7 and therefore breaking changes has been respected and excludes from the TYPO3 policies regarding breaking changes as it is not enforced. This change modifies two tests to assert results based on the used symfony version. [1] symfony/symfony#50867 [2] symfony/symfony@7050bc82dd25c540958 Resolves: #102766 Related: #102746 Releases: 12.4 Change-Id: I0624f33ff270ba793054d0ff84810beee1a98c06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82358 Reviewed-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: core-ci <typo3@b13.com> Tested-by: Stefan Bürk <stefan@buerk.tech>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/backend
that referenced
this pull request
Jan 6, 2024
Symfony 7 removed deprecated code paths [1][2] and therefore started using strict `in_array()` check for the `in` and `notIn` condition in the expression language. With #102746 the usage of symfony 7 has been allowed, which itself introduces breaking changes. It is optional to upgrade to symfony 7 and therefore breaking changes has been respected and excludes from the TYPO3 policies regarding breaking changes as it is not enforced. This change modifies two tests to assert results based on the used symfony version. [1] symfony/symfony#50867 [2] symfony/symfony@7050bc82dd25c540958 Resolves: #102766 Related: #102746 Releases: 12.4 Change-Id: I0624f33ff270ba793054d0ff84810beee1a98c06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82358 Reviewed-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: core-ci <typo3@b13.com> Tested-by: Stefan Bürk <stefan@buerk.tech>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/frontend
that referenced
this pull request
Jan 6, 2024
Symfony 7 removed deprecated code paths [1][2] and therefore started using strict `in_array()` check for the `in` and `notIn` condition in the expression language. With #102746 the usage of symfony 7 has been allowed, which itself introduces breaking changes. It is optional to upgrade to symfony 7 and therefore breaking changes has been respected and excludes from the TYPO3 policies regarding breaking changes as it is not enforced. This change modifies two tests to assert results based on the used symfony version. [1] symfony/symfony#50867 [2] symfony/symfony@7050bc82dd25c540958 Resolves: #102766 Related: #102746 Releases: 12.4 Change-Id: I0624f33ff270ba793054d0ff84810beee1a98c06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82358 Reviewed-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: core-ci <typo3@b13.com> Tested-by: Stefan Bürk <stefan@buerk.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inandnot inoperators now use strict comparison [ExpressionLanguage] Deprecate loose comparisons when using the "in" operator #49064