-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpClient] Allow custom working directory in TestHttpServer #50814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with this enabled we could think of new frameworkbundle config, to route all clients to the test server, so we guarantee no external traffic occurs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs something in the changelog
nicolas-grekas
approved these changes
Jun 29, 2023
javiereguiluz
approved these changes
Jun 29, 2023
fabpot
approved these changes
Jun 30, 2023
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jun 30, 2023
…pServer (ro0NL) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [HttpClient] Allow custom working directory in TestHttpServer | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> eases mocking by a lot :) Commits ------- c8f1f9a [HttpClient] Allow custom working directory in TestHttpServer
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eases mocking by a lot :)