8000 [HttpClient] Allow custom working directory in TestHttpServer by ro0NL · Pull Request #50814 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[HttpClient] Allow custom working directory in TestHttpServer #50814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

[HttpClient] Allow custom working directory in TestHttpServer #50814

wants to merge 0 commits into from

Conversation

ro0NL
Copy link
Contributor
@ro0NL ro0NL commented Jun 28, 2023
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

eases mocking by a lot :)

@carsonbot carsonbot added this to the 6.4 milestone Jun 28, 2023
@ro0NL ro0NL changed the title [HttpClient] Make test server extensible [HttpClient] Make test server reusable Jun 28, 2023
@ro0NL
Copy link
Contributor Author
ro0NL commented Jun 28, 2023

with this enabled we could think of new frameworkbundle config, to route all clients to the test server, so we guarantee no external traffic occurs

Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs something in the changelog

@ro0NL ro0NL changed the title [HttpClient] Make test server reusable [HttpClient] Allow custom working directory for TestHttpServer Jun 29, 2023
@ro0NL ro0NL changed the title [HttpClient] Allow custom working directory for TestHttpServer [HttpClient] Allow custom working directory in TestHttpServer Jun 29, 2023
@fabpot
Copy link
Member
fabpot commented Jun 30, 2023

Thank you @ro0NL.

fabpot added a commit that referenced this pull request Jun 30, 2023
…pServer (ro0NL)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[HttpClient] Allow custom working directory in TestHttpServer

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

eases mocking by a lot :)

Commits
-------

c8f1f9a [HttpClient] Allow custom working directory in TestHttpServer
@fabpot fabpot closed this Jun 30, 2023
@ro0NL ro0NL deleted the patch-1 branch June 30, 2023 06:36
This was referenced Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0