8000 [PhpUnitBridge] Require PHPUnit 9.6 by default by nicolas-grekas · Pull Request #50760 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PhpUnitBridge] Require PHPUnit 9.6 by default #50760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2023
Merged

[PhpUnitBridge] Require PHPUnit 9.6 by default #50760

merged 1 commit into from
Jun 24, 2023

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Related to symfony/recipes#1219

@carsonbot carsonbot added this to the 6.3 milestone Jun 23, 2023
@nicolas-grekas nicolas-grekas changed the title [HttpFoundation] Make Request::getPayload() return an empty InputBag if request body is empty [PhpUnitBridge] Require PHPUnit 9.6 by default Jun 23, 2023
@carsonbot carsonbot changed the title [PhpUnitBridge] Require PHPUnit 9.6 by default [HttpFoundation] Require PHPUnit 9.6 by default Jun 23, 2023
@fabpot
Copy link
Member
fabpot commented Jun 24, 2023

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 4043374 into symfony:6.3 Jun 24, 2023
@nicolas-grekas nicolas-grekas deleted the pub-96 branch June 24, 2023 12:49
@fabpot fabpot mentioned this pull request Jun 26, 2023
Merged
@carsonbot carsonbot changed the title [HttpFoundation] Require PHPUnit 9.6 by default [PhpUnitBridge] Require PHPUnit 9.6 by default Jun 27, 2023
@maelanleborgne maelanleborgne mentioned this pull request Nov 21, 2023
Merged
weaverryan added a commit to symfony/maker-bundle that referenced this pull request Nov 29, 2023
@weaverryan
minor #1398 Fix tests CS violations (maelanleborgne)
8927837 
This PR was squashed before being merged into the 1.x-dev branch.

Discussion
----------

Fix tests CS violations

Lately CI checks fail because of an [upgrade of the default phpunit version used in phpunit-bridge](symfony/symfony#50760). This PR fixes this in the bundle's tests. And also a couple of minor cs fixes.

(EDIT: just noticed the CS part was fixed in #1397 just earlier)

Commits
-------

47137b2 Fix tests CS violations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @fabpot @GromNaN @derrabus @carsonbot
0