8000 [HttpKernel] when configuring the container add services_{env} with php extension by helyakin · Pull Request #50754 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] when configuring the container add services_{env} with php extension #50754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

[HttpKernel] when configuring the container add services_{env} with php extension #50754

merged 1 commit into from
Jun 28, 2023

Conversation

helyakin
Copy link
@helyakin helyakin commented Jun 23, 2023 •
edited by nicolas-grekas
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets none
License MIT

Hello the community

This is my first PR attempt.

So after reading this documentation and unsuccessfully trying to load my service_test.php, I've noticed that the configureContainer(..) function in the MicroKernelTrait file was not configured to automatically load this file.

So either we should fix the documentation, either we should fix the configuration.

Since this the framework-bundle is backed by Alximy I figured it would be cool 😎 to try and fix 🐛 the configuration.

Anyway share me your thoughts about what should be done !

And I wanted to say that php service configuration is 🔥 so shoutout to the one who did this (I think it's you @nicolas-grekas with this PR right ? 💪🏻)

Also big thanks to @jeremyFreeAgent for debugging this with me and @HeahDude for showing me the php service configuration PR.

@carsonbot carsonbot added this to the 6.4 milestone Jun 23, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for bug fixes to 3.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title 🐛 (kernel) when configuring the container add services with php extension [HttpKernel] 🐛 (kernel) when configuring the container add services with php extension Jun 23, 2023
@helyakin helyakin changed the base branch from 6.4 to 3.4 June 23, 2023 10:31
@helyakin helyakin changed the base branch from 3.4 to 6.3 June 23, 2023 10:31
@helyakin helyakin changed the base branch from 6.3 to 6.4 June 23, 2023 10:31
chalasr
chalasr approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member
@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's a bit late and despite when() is the new best practice, I think this doesn't hurt. Not having these files loaded when moving config from yaml to php can be surprising, formats are used to behave the same as each other.

@helyakin helyakin changed the title [HttpKernel] 🐛 (kernel) when configuring the container add services with php extension [HttpKernel] when configuring the container add services_{env} with php extension Jun 23, 2023
@nicolas-grekas
Copy link
Member

We didn't add this because this can be done in PHP directly: if ('dev' === $env) etc.
Adding this doesn't hurt of course (but it's not a bugfix)

javiereguiluz
javiereguiluz approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice first contribution to Symfony and with a perfectly explained reasoning behind it. Thanks Marvin!

@javiereguiluz javiereguiluz added Feature and removed Bug labels Jun 28, 2023
@helyakin
Copy link
Author

Thank you everyone for your feedbacks, and thank you @javiereguiluz for those very nice words 😊

I'm really happy to have finally made my first contribution to Symfony 👯 !

@chalasr
Copy link
Member
chalasr commented Jun 28, 2023

Thank you @helyakin.

@chalasr chalasr merged commit af44385 into symfony:6.4 Jun 28, 2023
@chalasr
Copy link
Member
chalasr commented Jun 28, 2023

I didn't open a documentation issue because I think there's no impact there, but I may be wrong.
@helyakin if you could have a look and create an issue or PR if you find something that needs to be updated, that'd be great.

This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature HttpKernel Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
7 participants
@helyakin @carsonbot @nicolas-grekas @chalasr @javiereguiluz @xabbuh @derrabus
0