[Messenger Doctrine] Fixed regression by #50524 causing data loss #50717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "6.3". Cheers! Carsonbot |
|
Ok, according to doctrine/dbal#5766 there's no replacement for |
|
Replaced by #50742, thanks for raising this. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 22, 2023
…rekas) This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] Preserve existing Doctrine schema | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no (fixing a not released bug) | New feature? | no | Deprecations? | no | Tickets | Fix #50717 | License | MIT | Doc PR | - [Inlining](https://github.com/symfony/symfony/pull/50742/files#diff-2a38c9deb498eec50126c297bb3d094c8efb29364934e902d6481761ace6f20a) since Doctrine deprecated "toSaveSql" without providing an alternative. Cleaning up a few unneeded calls to `ORMSetup::createConfiguration()` also. Commits ------- 96c227a [Messenger] Preserve existing Doctrine schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression caused by #50524
When using
$platform->getAlterSchemaSQL($schemaDiff)instead of$schemaDiff->toSaveSql($platform)causes to call\Doctrine\DBAL\Schema\SchemaDiff::_toSql($platform, false)instead of\Doctrine\DBAL\Schema\SchemaDiff::_toSql($platform, true). When $saveMode=false the diff from the schema is getting remove, so actually all other tables ... in the DB are getting deletedFollow up to #50716 which was closed automatically by mistake 😊