10000 Make some classes final by lyrixx · Pull Request #50660 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Make some classes final #50660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make some classes final #50660

wants to merge 1 commit into from

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Jun 14, 2023
Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@lyrixx lyrixx requested review from dunglas and yceruto as code owners June 14, 2023 13:03
@carsonbot carsonbot added this to the 7.0 milestone Jun 14, 2023
@lyrixx lyrixx mentioned this pull request Jun 21, 2023
Merged
derrabus added a commit that referenced this pull request Jun 22, 2023
@derrabus
minor #50735 [Serializer] Refactor tests to not extends ObjectNormali…
15f384c 
…zer (lyrixx)

This PR was merged into the 6.3 branch.

Discussion
----------

[Serializer] Refactor tests to not extends ObjectNormalizer

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

see #50660 (comment)

Commits
-------

2269c3f [Serializer] Refactor tests to not extends ObjectNormalizer
@nicolas-grekas
Copy link
Member

(rebase needed)

@lyrixx
Copy link
Member Author
lyrixx commented Jun 27, 2023

I need to finish #50736 first

@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

nicolas-grekas added a commit that referenced this pull request Jun 30, 2023
@nicolas-grekas
minor #50660 Make some classes final (lyrixx)
f9c9ec7 
This PR was merged into the 7.0 branch.

Discussion
----------

Make some classes final

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

f39ede4 Make some classes final
@lyrixx
Copy link
Member Author
lyrixx commented Jun 30, 2023

This is weird, the PR has not been closed?!

@nicolas-grekas
Copy link
Member

🤷

@nicolas-grekas nicolas-grekas closed this 9271 Jun 30, 2023
@lyrixx lyrixx deleted the final branch June 30, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof left review comments

@derrabus derrabus derrabus left review comments

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lyrixx @nicolas-grekas @stof @derrabus @carsonbot
0