8000 [DoctrineBridge] Cleanup tests by fancyweb · Pull Request #50568 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DoctrineBridge] Cleanup tests #50568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2023
Merged

[DoctrineBridge] Cleanup tests #50568

merged 1 commit into from
Jun 5, 2023

Conversation

fancyweb
Copy link
Contributor
@fancyweb fancyweb commented Jun 5, 2023
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

AttributeDriver is available since doctrine/orm 2.9.0 and we already conflict with < 2.12.0 so we can logically clean the annotations and the check

@carsonbot carsonbot added this to the 6.4 milestone Jun 5, 2023
@fancyweb fancyweb force-pushed the doctrine-bridge/cleanup-tests branch 2 times, most recently from 32d16cc to 306b99b Compare June 5, 2023 15:45
@fancyweb fancyweb force-pushed the doctrine-bridge/cleanup-tests branch from 306b99b to 27c78a3 Compare June 5, 2023 15:48
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 42d43b7 into symfony:6.4 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @nicolas-grekas @stof @carsonbot
0