[Validator] GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations. #50540
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for features / 5.4, 6.2, or 6.3 for bug fixes". Cheers! Carsonbot |
|
To make the CI pass, you need to regenerate the |
|
@stof I'm trying but I am getting an error The phpunit folder is not there, should it be? |
|
@upchuk run |
|
@stof thanks. Did that but now I get I think you can just go ahead and make the fix yourself, it's much faster :D |
…s in favor of docblock annotations.
|
Thank you @upchuk. |
Uh oh!
There was an error while loading. Please reload this page.