8000 [Validator] GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations. by upchuk · Pull Request #50540 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations. #50540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2023
Merged

[Validator] GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations. #50540

merged 1 commit into from
Jun 5, 2023

Conversation

upchuk
Copy link
Contributor
@upchuk upchuk commented Jun 2, 2023 •
edited by xabbuh
Loading
Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50526
License MIT
Doc PR

@carsonbot carsonbot added this to the 6.4 milestone Jun 2, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for features / 5.4, 6.2, or 6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@upchuk upchuk mentioned this pull request Jun 2, 2023
Closed
@upchuk upchuk changed the base branch from 6.4 to 6.3 June 2, 2023 13:10
@stof
Copy link
Member
stof commented Jun 2, 2023

To make the CI pass, you need to regenerate the .github/expected-missing-return-types.diff file (instructions for that are at the top of the file) so that the CI does not complain about not using native types on those methods.

@wouterj wouterj modified the milestones: 6.4, 6.3 Jun 2, 2023
@upchuk
Copy link
Contributor Author
upchuk commented Jun 2, 2023

@stof I'm trying but I am getting an error Uncaught Error: Failed opening required '/var/www/html/.github/../.phpunit/phpunit/vendor/autoload.php', when i run SYMFONY_PATCH_TYPE_DECLARATIONS='force=2&php=8.1' php .github/patch-types.php.

The phpunit folder is not there, should it be?

@stof
Copy link
Member
stof commented Jun 2, 2023

@upchuk run ./phpunit install first

@upchuk
Copy link
Contributor Author
upchuk commented Jun 5, 2023

@stof thanks. Did that but now I get

[05-Jun-2023 06:52:32 UTC] PHP Fatal error:  Uncaught RuntimeException: Case mismatch between loaded and declared class names: "Doctrine\DBAL\Platforms\MySqlPlatform" vs "Doctrine\DBAL\Platforms\MySQLPlatform". in /var/www/html/src/Symfony/Component/ErrorHandler/DebugClassLoader.php:331

I think you can just go ahead and make the fix yourself, it's much faster :D

@carsonbot carsonbot changed the title GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations. [Validator] GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations. Jun 5, 2023
@nicolas-grekas
Copy link
Member

Thank you @upchuk.

@nicolas-grekas nicolas-grekas merged commit 1cceec1 into symfony:6.3 Jun 5, 2023
@fabpot fabpot mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Validator
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
6 participants
@upchuk @carsonbot @stof @nicolas-grekas @wouterj @xabbuh
0