8000 [RemoteEvent][Webhook] Add Sendinblue support by blaugueux · Pull Request #50516 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[RemoteEvent][Webhook] Add Sendinblue support #50516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RemoteEvent][Webhook] Add Sendinblue support #50516

wants to merge 1 commit into from

Conversation

blaugueux
Copy link
Contributor
Q A
Branch 6.4
Bug fix no
New feature yes
Deprecations no
Tickets
License MIT
Doc PR

@carsonbot carsonbot added this to the 6.4 milestone May 31, 2023
@blaugueux blaugueux requested a review from OskarStark as a code owner June 4, 2023 07:35
@blaugueux
Copy link
Contributor Author

@OskarStark Can you please tell me if I need to work on something on this PR?

@OskarStark OskarStark requested a review from fabpot June 19, 2023 06:27
@OskarStark
Copy link
Contributor

Looks good from my side, WDYT @fabpot ?

@stof
Copy link
Member
stof commented Jun 19, 2023

Given that Sendinblue has rebranded as Brevo and there is an in-progress PR to create a Brevo bridge using the new domain, I would vote -1 for this PR in its current state. The webhook and remote event integrations should be added to the new bridge, not to the old one.

@fabpot
Copy link
Member
fabpot commented Jul 31, 2023

@blaugueux Can you work on adding this to the new bridges?

@blaugueux
Copy link
Contributor Author

@fabpot of course. Just give me few days!

@blaugueux
Copy link
Contributor Author

@fabpot #51264 integration into the new Brevo bridge.

@fabpot
Copy link
Member
fabpot commented Aug 4, 2023

Thank you, let's close here then.

@fabpot fabpot closed this Aug 4, 2023
@blaugueux blaugueux deleted the sendinblue-webhook branch August 4, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot Awaiting requested review from fabpot

Assignees
No one assigned
Labels
RemoteEvent Status: Needs Review Webhook
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@blaugueux @OskarStark @stof @fabpot @carsonbot
0