8000 [RemoteEvent][Webhook] Add Mailjet support by blaugueux · Pull Request #50502 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[RemoteEvent][Webhook] Add Mailjet support #50502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2023
Merged

[RemoteEvent][Webhook] Add Mailjet support #50502

merged 1 commit into from
Aug 4, 2023

Conversation

blaugueux
Copy link
Contributor
Q A
Branch 6.4
Bug fix no
New feature yes
Deprecations no
Tickets
License MIT
Doc PR

@carsonbot carsonbot added this to the 6.4 milestone May 31, 2023
@carsonbot carsonbot changed the title [Webhook][RemoteEvent] Add Mailjet support. [RemoteEvent][Webhook] Add Mailjet support. May 31, 2023
@blaugueux blaugueux changed the title [RemoteEvent][Webhook] Add Mailjet support. [RemoteEvent][Webhook] Add Mailjet support May 31, 2023
fabpot
fabpot approved these changes May 31, 2023
View reviewed changes
Copy link
Member
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion to make code shorter and maybe more readable.

fabpot
fabpot requested changes Jun 3, 2023
View reviewed changes
Copy link
Member
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blaugueux You need to add "symfony/webhook": "^6.3" in the require-dev section of the Mailjet bridge composer.json file to make tests pass.

@blaugueux blaugueux requested a review from OskarStark as a code owner June 4, 2023 07:30
@OskarStark OskarStark requested a review from fabpot June 4, 2023 18:52
@fabpot
Copy link
Member
fabpot commented Jul 31, 2023

@blaugueux Can you rebase to see if the tests would pass?

@fabpot
Copy link
Member
fabpot commented Aug 4, 2023

Thank you @blaugueux.

@fabpot fabpot merged commit 0ce5112 into symfony:6.4 Aug 4, 2023
@fabpot fabpot mentioned this pull request Aug 4, 2023
Closed
@blaugueux blaugueux deleted the mailjet-webook branch August 4, 2023 07:55
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
RemoteEvent Status: Reviewed Webhook
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@blaugueux @fabpot @OskarStark @carsonbot
0