8000 [7.0] Remove hacks that made the CI green by nicolas-grekas · Pull Request #50407 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[7.0] Remove hacks that made the CI green #50407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

[7.0] Remove hacks that made the CI green #50407

merged 1 commit into from
May 30, 2023

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented May 23, 2023 •
edited
Loading
Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Follows #50404

The Windows build is blocked by ext-redis and ext-apcu not being available as DLL for PHP 8.2. /cc @weltling 🙏

It's time to allow Symfony 7 again :)

We also need a sigchild-enabled PHP, which @derrabus knows how to build :)

@carsonbot carsonbot added this to the 7.0 milestone May 23, 2023
@Seldaek
Copy link
Member
Seldaek commented May 23, 2023

See composer/composer#11474 - Composer should now be good to go.

@derrabus
Copy link
Member

doctrine/orm#10724

@derrabus
Copy link
Member

We also need a sigchild-enabled PHP, which @derrabus knows how to build :)

Which 8.2.x release exactly do we want for that? We've always used an early release: 7.1.3, 7.2.5, 8.0.2, 8.1.2.

@nicolas-grekas
Copy link
Member Author

For 8.1, we use 8.1.0 (see appveyor), so I'd go with 8.2.0 on appveyor also.

@derrabus
Copy link
Member

https://gitlab.com/derrabus/php-binaries-with-pcntl-and-sigchild-enabled/-/jobs/4358439603/artifacts/file/build/php-8.2.0-pcntl-sigchild.tar.bz2

@nicolas-grekas
Copy link
Member Author

Thanks! I'm AFK but managed to upload this to the binary-utils repo from my phone :)
Can you please send a PR to update the job accordingly?

nicolas-grekas added a commit to nicolas-grekas/CssToInlineStyles that referenced this pull request May 30, 2023
@nicolas-grekas
Allow Symfony 7
ea91202 
Needed to unlock symfony/symfony#50407
@nicolas-grekas nicolas-grekas mentioned this pull request May 30, 2023
Merged
@nicolas-grekas
Copy link
Member Author

Thanks to everybody involved!

@nicolas-grekas nicolas-grekas merged commit c574955 into symfony:7.0 May 30, 2023
@nicolas-grekas nicolas-grekas deleted the true-70-82 branch May 30, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @Seldaek @derrabus @carsonbot
0