8000 [AssetMapper] Sometimes asset contents are built from non-asset files by weaverryan · Pull Request #50400 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[AssetMapper] Sometimes asset contents are built from non-asset files #50400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

[AssetMapper] Sometimes asset contents are built from non-asset files #50400

merged 1 commit into from
May 23, 2023

Conversation

weaverryan
Copy link
Member
Q A
Branch? 6.3
Bug fix? yes-ish
New feature? yes-ish
Deprecations? no
Tickets None
License MIT
Doc PR Still TODO

Apologies again for the late thing - I'm really trying to push the component to find critical bugs or missing items.

In StimulusBundle, we dynamically build the contents of a controllers.js mapped asset from the assets/controllers.json file. This PR allows us to "bust" that asset's cache when assets/controllers.json is modified. Right now, it would be a bug in StimulusBundle that we can't really work around.

Other use-cases: someone decides to write an asset compiler that runs Tailwind automatically on a CSS file, and they want that dynamic asset to "vary" on the tailwind.config.js file.

Thanks!

@carsonbot carsonbot added this to the 6.3 milestone May 23, 2023
@nicolas-grekas nicolas-grekas added ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" and removed ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" labels May 23, 2023
@nicolas-grekas nicolas-grekas changed the base branch from 6.4 to 6.3 May 23, 2023 16:47
@nicolas-grekas
Copy link
Member

Thank you @weaverryan.

@nicolas-grekas nicolas-grekas merged commit 03d8302 into symfony:6.3 May 23, 2023
@weaverryan weaverryan deleted the asset-mapper-non-asset-file-resources branch May 23, 2023 17:26
@fabpot fabpot mentioned this pull request May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
AssetMapper Bug Feature Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@weaverryan @nicolas-grekas @stof @carsonbot
0