8000 [FrameworkBundle] Fix Workflow without a marking store definition uses marking store definition of previously defined workflow by krciga22 · Pull Request #50362 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Fix Workflow without a marking store definition uses marking store definition of previously defined workflow #50362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

[FrameworkBundle] Fix Workflow without a marking store definition uses marking store definition of previously defined workflow #50362

merged 1 commit into from
May 19, 2023

Conversation

krciga22
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48099
License MIT
Doc PR symfony/symfony-docs#...

Fixed a bug in the Framework Bundle with the registerWorkflowConfiguration() method not initializing $workflowMarkingStore to null when processing each workflow. This results in subsequent workflows reusing the previously set $workflowMarkingStore value if one has not been explicitly configured.

In the example below, workflow_b has no marking_store configured, so it will utilize the marking_store configuration for workflow_a instead of the default MethodMarkingStore due to this bug.

framework:
    workflows:
        workflow_a:
            type: 'state_machine'
            marking_store:
                type: 'method'
                property: 'status'
        workflow_b:
            type: 'state_machine'

@carsonbot carsonbot added this to the 5.4 milestone May 18, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@krciga22 @nicolas-grekas
[FrameworkBundle] Fix Workflow without a marking store definition use…
9cc5cbf 
…s marking store definition of previously defined workflow
@nicolas-grekas
Copy link
Member

Thank you @krciga22.

@nicolas-grekas nicolas-grekas merged commit 3856956 into symfony:5.4 May 19, 2023
This was referenced May 22, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@krciga22 @carsonbot @nicolas-grekas
0