8000 [Notifier][TurboSMS] Fix get sender name by ZhukV · Pull Request #50352 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier][TurboSMS] Fix get sender name #50352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2023
Merged

[Notifier][TurboSMS] Fix get sender name #50352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix get sender name in turbosms notifier
  • Loading branch information
@ZhukV
ZhukV committed May 17, 2023
commit d3486ddfa8061d7d781238fce00ce628aa8ead87
11 changes: 10 additions & 1 deletion src/Symfony/Component/Notifier/Bridge/TurboSms/Tests/TurboSmsTransportTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,16 @@ public function testSuccessfulSend()
]))
;

$client = new MockHttpClient(static function () use ($response): ResponseInterface {
$client = new MockHttpClient(static function (string $method, string $url, array $options) use ($response): ResponseInterface {
$body = json_decode($options['body'], true);
self::assertSame([
'sms' => [
'sender' => 'sender',
'recipients' => ['380931234567'],
'text' => 'Тест/Test',
]
], $body);

return $response;
});

Expand Down
3 changes: 2 additions & 1 deletion src/Symfony/Component/Notifier/Bridge/TurboSms/TurboSmsTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ protected function doSend(MessageInterface $message): SentMessage
$this->assertValidSubject($message->getSubject());

$fromMessage = $message->getFrom();
if (null !== $fromMessage) {

if ($fromMessage) {
$this->assertValidFrom($fromMessage);
$from = $fromMessage;
} else {
Expand Down
0