8000 [PropertyInfo] Fix `PhpStanExtractor` when constructor has no docblock by HypeMC · Pull Request #50332 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyInfo] Fix PhpStanExtractor when constructor has no docblock #50332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2023
Merged

[PropertyInfo] Fix PhpStanExtractor when constructor has no docblock #50332

merged 1 commit into from
May 16, 2023

Conversation

HypeMC
Copy link
Contributor
@HypeMC HypeMC commented May 15, 2023 •
edited
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Currently the PhpStanExtractor::getTypesFromConstructor() method throws an exception when a constructor has no docblock, instead of returning null:

PHPStan\PhpDocParser\Parser\ParserException: Unexpected token "", expected '/**' at offset 0

@HypeMC HypeMC requested a review from dunglas as a code owner May 15, 2023 19:58
@carsonbot carsonbot added this to the 5.4 milestone May 15, 2023
@HypeMC HypeMC force-pushed the fix-phpstanextractor-gettypesfromconstructor branch from 3f44728 to a55feaa Compare May 15, 2023 20:11
@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit 03aa9c1 into symfony:5.4 May 16, 2023
@HypeMC HypeMC deleted the fix-phpstanextractor-gettypesfromconstructor branch May 16, 2023 12:26
This was referenced May 22, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@HypeMC @nicolas-grekas @stof @carsonbot
0