8000 Consistently use var $container to reference the container builder+configurator by nicolas-grekas · Pull Request #50282 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Consistently use var $container to reference the container builder+configurator #50282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

Consistently use var $container to reference the container builder+configurator #50282

merged 1 commit into from
May 10, 2023

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Related to symfony/symfony-docs#18299

The vast majority of the code base uses $container to reference either the ContainerBuilder or the ContainerConfigurator, depending on the context.

There are just a few inconsistencies, fixed in this PR.

@carsonbot carsonbot added this to the 6.3 milestone May 10, 2023
@nicolas-grekas nicolas-grekas merged commit 51889c0 into symfony:6.3 May 10, 2023
@nicolas-grekas nicolas-grekas deleted the container-var branch May 10, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @carsonbot
0