8000 [DependencyInjection] Do not check errored definitions’ type by MatTheCat · Pull Request #50246 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Do not check errored definitions’ type #50246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

[DependencyInjection] Do not check errored definitions’ type #50246

merged 1 commit into from
May 5, 2023

Conversation

@MatTheCat
Copy link
Contributor
@MatTheCat MatTheCat commented May 5, 2023
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Needed for #50234
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 6.3 milestone May 5, 2023
@carsonbot
Copy link
carsonbot commented May 5, 2023

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@MatTheCat MatTheCat changed the base branch from 6.3 to 5.4 May 5, 2023 14:42
@MatTheCat MatTheCat force-pushed the errored-definition-type-check branch from ccf9224 to 668be94 Compare May 5, 2023 14:43
@MatTheCat MatTheCat changed the title [DependencyInjection] Do not ch 8000 eck errored definitions’s type [DependencyInjection] Do not check errored definitions’ type May 5, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 5.4 May 5, 2023
@nicolas-grekas
Copy link
Member
nicolas-grekas commented May 5, 2023

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit af784ae into symfony:5.4 May 5, 2023
@MatTheCat MatTheCat deleted the errored-definition-type-check branch May 5, 2023 15:32
@fabpot fabpot mentioned this pull request May 7, 2023
Merged
This was referenced May 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof approved these changes

Assignees

No one assigned

Labels

Bug DependencyInjection Status: Reviewed

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@MatTheCat @carsonbot @nicolas-grekas @stof
0