8000 [AssetMapper] Fixing wrong values being output in command by weaverryan · Pull Request #50215 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[AssetMapper] Fixing wrong values being output in command #50215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

[AssetMapper] Fixing wrong values being output in command #50215

merged 1 commit into from
May 2, 2023

Conversation

@weaverryan
Copy link
Member
@weaverryan weaverryan commented May 2, 2023
Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? none
Tickets None
License MIT
Doc PR Not needed

A leftover from working on the component. $newPackages is an indexed array of ImportMapEntry. So, before this, the message would output "new packages (0, 1)". Now:

Screenshot 2023-05-02 at 12 59 12 PM

Cheers!

@carsonbot carsonbot added this to the 6.3 milestone May 2, 2023
@chalasr
Copy link
Member
chalasr commented May 2, 2023

Thanks @weaverryan.

@chalasr chalasr merged commit 6042c00 into symfony:6.3 May 2, 2023
@weaverryan weaverryan deleted the importmaps-fix-command-output branch May 3, 2023 18:35
@fabpot fabpot mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

No one assigned

Labels

Bug Status: Reviewed

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

4 participants

@weaverryan @chalasr @OskarStark @carsonbot
0