8000 [Translation] throw again if non-excluded abstract services are tagged by xabbuh · Pull Request #50186 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translation] throw again if non-excluded abstract services are tagged #50186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Translation] throw again if non-excluded abstract services are tagged #50186

wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Apr 28, 2023
Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #49850 (comment)
License MIT
Doc PR

@carsonbot carsonbot added this to the 6.3 milestone Apr 28, 2023
@stof
Copy link
Member
stof commented Apr 28, 2023

This is breaking the previous change, by not processing excluded services at all anymore, while they still needed to be processed for the discovery of available constraints.

This compiler was instentionally changed to process excluded service definitions (which are not returned anymore by findTaggedServiceIds in response to the comment you linked)

@nicolas-grekas
Copy link
Member

@stof is correct.

@xabbuh xabbuh deleted the pr-49850 branch April 28, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Status: Needs Review Translation
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @stof @nicolas-grekas @carsonbot
0