8000 [FrameworkBundle] Fix services usages output for text descriptor by rmikalkenas · Pull Request #49849 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Fix services usages output for text descriptor #49849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[FrameworkBundle] Fix services usages output for text descriptor #49849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ protected function describeContainerDefinition(Definition $definition, array $op
}

$inEdges = null !== $builder && isset($options['id']) ? $this->getServiceEdges($builder, $options['id']) : [];
$tableRows[] = ['Usages', $inEdges ? implode(', ', $inEdges) : 'none'];
$tableRows[] = ['Usages', $inEdges ? implode(\PHP_EOL, $inEdges) : 'none'];
Copy link
Member
@nicolas-grekas nicolas-grekas Mar 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about limiting to eg 3 and show "and X more" instead? I agree with you that the long output is useless

Copy link
Contributor Author
@rmikalkenas rmikalkenas Mar 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolas-grekas, I was thinking about it, but isn't it the main reason of debug command to clearly show the details about the resource?
Another option I thought was to implement a new command argument which would show usages (similar to show-arguments), but this would result to BC break, because by default it would no longer show usages..
IMO leaving all usages, but showing them in a single column is better (attaching screenshots of differences)
WDYT?

image
image


$options['output']->table($tableHeaders, $tableRows);
}
Expand Down
0