8000 [Scheduler] Make some properties readonly by fancyweb · Pull Request #49799 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Scheduler] Make some properties readonly #49799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2023
Merged

[Scheduler] Make some properties readonly #49799

merged 1 commit into from
Mar 25, 2023

Conversation

fancyweb
Copy link
Contributor
Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@carsonbot carsonbot added this to the 6.3 milestone Mar 24, 2023
fancyweb
fancyweb commented Mar 24, 2023
View reviewed changes
src/Symfony/Component/Scheduler/Tests/Generator/CheckpointTest.php
@@ -105,7 +105,7 @@ public function testWithCacheSave()
{
$checkpoint = new Checkpoint('cache', new NoLock(), $cache = new ArrayAdapter());
$now = new \DateTimeImmutable('2020-02-20 20:20:20Z');
$checkpoint->acquire($n = $now->modify('-1 hour'));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable.

fabpot
fabpot approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think most of them are needed (tests for example), but let's merge and move forward :)

@fabpot
Copy link
Member
fabpot commented Mar 25, 2023

Thank you @fancyweb.

@fabpot fabpot merged commit c2090d3 into symfony:6.3 Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Scheduler Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fancyweb @fabpot @carsonbot
0