8000 [Console] Add missing ZSH mention in DumpCompletionCommand help by lyrixx · Pull Request #49765 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Add missing ZSH mention in DumpCompletionCommand help #49765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

[Console] Add missing ZSH mention in DumpCompletionCommand help #49765

merged 1 commit into from
Mar 28, 2023

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Mar 22, 2023
Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

See https://github.com/symfony/symfony/blob/6.2/src/Symfony/Component/Console/Resources/completion.zsh

And I check, it doesn't exist on 5.4

@lyrixx lyrixx requested a review from chalasr as a code owner March 22, 2023 10:12
@carsonbot carsonbot added this to the 6.2 milestone Mar 22, 2023
lyrixx
lyrixx commented Mar 22, 2023
View reviewed changes
stof
stof reviewed Mar 22, 2023
View reviewed changes
src/Symfony/Component/Console/Command/DumpCompletionCommand.php Outdated
@@ -55,7 +55,7 @@ protected function configure()
$this
->setHelp(<<<EOH
The <info>%command.name%</> command dumps the shell completion script required
to use shell autocompletion (currently, bash and fish completion is supported).
to use shell autocompletion (currently, bash, zsh and fish completion are supported).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this list should be generated from $this->getSupportedShells(), to avoid having to remember this help text each time we add a new supported shell.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, I forgot this PR! Fixed!

@lyrixx lyrixx force-pushed the console-completion-help branch 2 times, most recently from 34f3653 to 8ae562e Compare March 28, 2023 17:22
@lyrixx lyrixx force-pushed the console-completion-help branch from 8ae562e to fd957a9 Compare March 28, 2023 17:23
@fabpot
Copy link
Member
fabpot commented Mar 28, 2023

Thank you @lyrixx.

@fabpot fabpot merged commit eb9f258 into symfony:6.2 Mar 28, 2023
@lyrixx lyrixx deleted the console-completion-help branch March 28, 2023 18:43
@fabpot fabpot mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @fabpot @stof @carsonbot
0