8000 [Cache] Use binary type for ID column for PostgreSQL by alexndlm · Pull Request #49748 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Use binary type for ID column for PostgreSQL #49748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Cache] Use binary type for ID column for PostgreSQL #49748

wants to merge 3 commits into from

Conversation

alexndlm
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

When using PostgreSQL binary part of the cache item ID loses.

Previous tries:

@carsonbot carsonbot added this to the 6.3 milestone Mar 20, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@alexndlm alexndlm changed the base branch from 6.3 to 5.4 March 20, 2023 19:13
@alexndlm
Copy link
Contributor Author

@nicolas-grekas, would you please take a look?

@alexndlm
Copy link
Contributor Author

@nicolas-grekas, ping, ping.

@alexndlm
Copy link
Contributor Author

@nicolas-grekas , any updates?

@nicolas-grekas nicolas-grekas mentioned this pull request Mar 28, 2023
Merged
@nicolas-grekas
Copy link
Member

On second thought, I'd prefer a more seamless approach.
I submitted #49848 for 5.4 and also #49847 for 6.3.
Thanks for raising this issue and sending PRs!

fabpot added a commit that referenced this pull request Mar 29, 2023
@fabpot
bug #49848 [Cache] Fix storing binary keys when using pgsql (nicolas-…
2794527 
…grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[Cache] Fix storing binary keys when using pgsql

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #49748
| License       | MIT
| Doc PR        | -

Commits
-------

be88fd0 [Cache] Fix storing binary keys when using pgsql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Cache Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@alexndlm @carsonbot @nicolas-grekas
0