8000 [Serializer] GetSetMethodNormalizer::supportss should not check ignored methods by nikophil · Pull Request #49720 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] GetSetMethodNormalizer::supportss should not check ignored methods #49720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[Serializer] GetSetMethodNormalizer::supportss should not check ignored methods #49720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

namespace Symfony\Component\Serializer\Normalizer;

use Symfony\Component\Serializer\Annotation\Ignore;

/**
* Converts between objects with getter and setter methods and arrays.
*
Expand Down Expand Up @@ -81,17 +83,12 @@ private function supports(string $class): bool
*/
private function isGetMethod(\ReflectionMethod $method): bool
{
$methodLength = \strlen($method->name);

return
!$method->isStatic() &&
(
((str_starts_with($method->name, 'get') && 3 < $methodLength) ||
(str_starts_with($method->name, 'is') && 2 < $methodLength) ||
(str_starts_with($method->name, 'has') && 3 < $methodLength)) &&
0 === $method->getNumberOfRequiredParameters()
)
;
return !$method->isStatic()
&& (\PHP_VERSION_ID < 80000 || !$method->getAttributes(Ignore::class))
&& !$method->getNumberOfRequiredParameters()
&& ((2 < ($methodLength = \strlen($method->name)) && str_starts_with($method->name, 'is'))
|| (3 < $methodLength && (str_starts_with($method->name, 'has') || str_starts_with($method->name, 'get')))
);
}

/**
Expand Down
17 changes: 17 additions & 0 deletions src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
use Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor;
use Symfony\Component\PropertyInfo\Extractor\ReflectionExtractor;
use Symfony\Component\PropertyInfo\PropertyInfoExtractor;
use Symfony\Component\Serializer\Annotation\Ignore;
use Symfony\Component\Serializer\Exception\LogicException;
use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactory;
use Symfony\Component\Serializer\Mapping\Loader\AnnotationLoader;
Expand Down Expand Up @@ -430,6 +431,11 @@ public function testNoStaticGetSetSupport()
$this->assertFalse($this->normalizer->supportsNormalization(new ObjectWithJustStaticSetterDummy()));
}

public function testNotIgnoredMethodSupport()
{
$this->assertFalse($this->normalizer->supportsNormalization(new ClassWithIgnoreAttribute()));
}

public function testPrivateSetter()
{
$obj = $this->normalizer->denormalize(['foo' => 'foobar'], ObjectWithPrivateSetterDummy::class);
Expand Down Expand Up @@ -753,3 +759,14 @@ public function __call($key, $value)
throw new \RuntimeException('__call should not be called. Called with: '.$key);
}
}

class ClassWithIgnoreAttribute
{
public string $foo;

#[Ignore]
public function isSomeIgnoredMethod(): bool
{
return true;
}
}
0