8000 [String] Correct inflection of 'codes' and 'names' by GwendolenLynch · Pull Request #49681 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[String] Correct inflection of 'codes' and 'names' #49681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

[String] Correct inflection of 'codes' and 'names' #49681

merged 1 commit into from
Mar 17, 2023

Conversation

GwendolenLynch
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Singularizing of codes and names currently returns cod and nam. This PR simply adds them as suffixes, with tests.

@carsonbot carsonbot added this to the 5.4 milestone Mar 14, 2023
@nicolas-grekas
Copy link
Member

Thank you @GwendolenLynch.

@nicolas-grekas nicolas-grekas merged commit 6ab60c4 into symfony:5.4 Mar 17, 2023
@GwendolenLynch GwendolenLynch deleted the code-name-inflection branch March 24, 2023 05:50
This was referenced Mar 31, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed String
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@GwendolenLynch @nicolas-grekas @OskarStark @carsonbot
0