8000 [HttpFoundation] Use `@final` to make `UrlHelper` mockable by HypeMC · Pull Request #49600 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Use @final to make UrlHelper mockable #49600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[HttpFoundation] Use @final to make UrlHelper mockable #49600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[HttpFoundation] Use @Final to make UrlHelper mockable
  • Loading branch information
@HypeMC
HypeMC committed Mar 15, 2023
commit d2b546cfa47fb46cb66dd911634dc6b914ecf963
1 change: 1 addition & 0 deletions src/Symfony/Component/HttpFoundation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ CHANGELOG
* Create migration for session table when pdo handler is used
* Add support for Relay PHP extension for Redis
* The `Response::sendHeaders()` method now takes an optional HTTP status code as parameter, allowing to send informational responses such as Early Hints responses (103 status code)
* Use `@final` to make `UrlHelper` mockable

6.2
---
Expand Down
4 changes: 3 additions & 1 deletion src/Symfony/Component/HttpFoundation/UrlHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
* A helper service for manipulating URLs within and outside the request scope.
*
* @author Valentin Udaltsov <udaltsov.valentin@gmail.com>
*
* @final
*/
final class UrlHelper
class UrlHelper
{
private RequestStack $requestStack;
private ?RequestContext $requestContext;
Expand Down
0