[Messenger] Fix TransportNamesStamp deserialization
#49548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | symfony#31490 (comment) | License | MIT | Doc PR | n/a Currently, when ones use `TransportNameStamp` the following exception occurs: ``` In Serializer.php line 125: [Symfony\Component\Messenger\Exception\MessageDecodingFailedException] Could not decode stamp: Cannot create an instance of "Symfony\Component\Messenger\Stamp\TransportNamesStamp" from serialized data because its constructor requires parameter "transports" to be present. In AbstractNormalizer.php line 384: [Symfony\Component\Serializer\Exception\MissingConstructorArgumentsException] Cannot create an instance of "Symfony\Component\Messenger\Stamp\TransportNamesStamp" from serialized data because its constructor requires parameter "transports" to be present. ``` This PR renames `TransportNamesStamp` constructor argument in order to match the accesor method (`getTranspdortNames`) so that deserialization work. I know this is technically a BC break but as far as I can tell the feature can not currently work this way and also named arguments are not covered by Symfony's BC if I remember correctly.
|
Thanks for fixing this. You were just a little quicker than me. Also seen this yesterday. |
|
A suggestion: would it be logical to typehint the getter with |
TransportNamesStamp deserialization
|
Hi guys, thanks for this PR. Once this PR gets merged, how long it'll take to release a new version? |
|
We do a release every month @tsantos84 so you can expect one in a bit less than 4 weeks. |
|
Good catch, thanks @tucksaun. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when ones use
TransportNameStampthe following exception can occur if they don't use native PHP serialization:This PR renames
TransportNamesStampconstructor argument in order to match the accessor method (getTransportNames) so that deserialization works when using the Serializer.I know this is technically a (small) BC break but Symfony's BC does not cover named arguments if I remember correctly.