10000 Add CI check ensuring interfaces have return types by wouterj · Pull Request #49439 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Add CI check ensuring interfaces have return types #49439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2023
Merged

Add CI check ensuring interfaces have return types #49439

merged 1 commit into from
Apr 22, 2023

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Feb 18, 2023
Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets Ref #47551
License MIT
Doc PR -

This adds a CI check to enforce all methods on an interface to have a return type (native or PHPdoc).

For now, this is a living version of the list I published in #47551. I'll rebase this PR whenever we add more types.

@carsonbot carsonbot added this to the 6.3 milestone Feb 18, 2023
@wouterj wouterj mentioned this pull request Feb 18, 2023
Closed
@wouterj wouterj force-pushed the return-types-ci-check branch from 5b1a263 to 8386d05 Compare February 18, 2023 12:08
@wouterj wouterj mentioned this pull request Mar 4, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Mar 6, 2023
@nicolas-grekas
minor #49599 [HttpFoundation][HttpKernel] Add missing void PHPdoc ret…
32f2ec9 
…urn types (wouterj)

This PR was merged into the 6.3 branch.

Discussion
----------

[HttpFoundation][HttpKernel] Add missing void PHPdoc return types

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no (void return types don't get a deprecation notice)
| Tickets       | Fix part of #47551 , ref #49439
| License       | MIT
| Doc PR        | -

Commits
-------

9bb72d7 [HttpFoundation][HttpKernel] Add missing void PHPdoc return types
@wouterj wouterj force-pushed the return-types-ci-check branch 2 times, most recently from 04248ce to fcb37b3 Compare March 18, 2023 13:21
@wouterj wouterj force-pushed the return-types-ci-check branch 2 times, most recently from 48541fd to d7ed67c Compare April 14, 2023 10:13
@stof stof force-pushed the return-types-ci-check branch from d7ed67c to f312232 Compare April 21, 2023 10:56
@fabpot fabpot force-pushed the return-types-ci-check branch from f312232 to b8ade5a Compare April 21, 2023 14:29
@wouterj wouterj force-pushed the return-types-ci-check branch from b8ade5a to ae8554b Compare April 21, 2023 19:18
@wouterj wouterj changed the title [WIP] Add CI check ensuring interfaces have return types Add CI check ensuring interfaces have return types Apr 21, 2023
@wouterj wouterj force-pushed the return-types-ci-check branch from ae8554b to 2d98e28 Compare April 21, 2023 21:52
@fabpot fabpot force-pushed the return-types-ci-check branch from 2d98e28 to 29ea860 Compare April 22, 2023 08:23
@fabpot
Copy link
Member
fabpot commented Apr 22, 2023

Thank you @wouterj.

@fabpot fabpot merged commit ed6e10a into symfony:6.3 Apr 22, 2023
@wouterj wouterj deleted the return-types-ci-check branch April 22, 2023 09:34
@wouterj wouterj mentioned this pull request Apr 22, 2023
Merged
wouterj added a commit that referenced this pull request Apr 22, 2023
@wouterj
minor #50114 [Serializer] Fix tests (wouterj)
0549a20 
This PR was merged into the 6.3 branch.

Discussion
----------

[Serializer] Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Add some missing void return types to test dummies. This fixes the tests broken by #49439

Commits
-------

e1faaae [Serializer] Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @fabpot @carsonbot
0