[Tests] Migrate data providers to static ones #49244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aae261e to
f6bfca6
Compare
OskarStark
approved these changes
Feb 5, 2023
| { | ||
| $data = []; | ||
| foreach ($objects as $name => $object) { | ||
| $description = file_get_contents(sprintf('%s/../Fixtures/%s.%s', __DIR__, $name, $this->getFormat())); | ||
| $description = file_get_contents(sprintf('%s/../Fixtures/%s.%s', __DIR__, $name, static::getFormat())); |
There was a problem hiding this comment.
We'd rather use self:: IMHO because this is more specific. We don't want to open test cases to extensibility (unless abstract test cases of course, for calls that are designed for that.)
There was a problem hiding this comment.
Taking note for the next ones. Thank you very much for taking care of this!
f6bfca6 to
36bc5ae
Compare
|
Thank you @alexandre-daubois. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 10, 2023
…e-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Tests] Migrate tests to static data providers | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes-ish | New feature? | no | Deprecations? | no | Tickets | Continuing #48668 (comment) | License | MIT | Doc PR | _NA_ This is yet another PR to continue the manual work needed for the migration of data providers to static ones. I also took the opportunity to pass a few `static::` to `self::` calls, as pointed out by Nicolas in this comment: #49244 (comment) cc `@OskarStark` 👋 Commits ------- 3b8b070 [Tests] Migrate tests to static data providers
symfony-splitter
pushed a commit
to symfony/web-profiler-bundle
that referenced
this pull request
Feb 10, 2023
…e-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Tests] Migrate tests to static data providers | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes-ish | New feature? | no | Deprecations? | no | Tickets | Continuing symfony/symfony#48668 (comment) | License | MIT | Doc PR | _NA_ This is yet another PR to continue the manual work needed for the migration of data providers to static ones. I also took the opportunity to pass a few `static::` to `self::` calls, as pointed out by Nicolas in this comment: symfony/symfony#49244 (comment) cc `@OskarStark` 👋 Commits ------- 3b8b07037b [Tests] Migrate tests to static data providers
nicolas-grekas
added a commit
that referenced
this pull request
Feb 10, 2023
This PR was merged into the 5.4 branch. Discussion ---------- Split and clean up tests | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a This pull request - [x] splits a test and removes a data provider to avoid creating test doubles in data providers Follows #49244. 💁♂️ This follows a brief discussion on Twitter (see https://twitter.com/VotrubaT/status/1622995017756291074). I do not expect this to be merged, but in my opinion, creating - test doubles - the system under test (not the case here, but I have observed it elsewhere) in data providers are anti-patterns. ~~Other than that, I have no idea what we are testing here.~~ Commits ------- 66e9fe1 Fix: Split and clean up tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating data providers to static ones, based on the failing CI of #48668
cc @OskarStark 👋