10000 [HttpFoundation] Fix bad return type in IpUtils::checkIp4() by tristankretzer · Pull Request #49141 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Fix bad return type in IpUtils::checkIp4() #49141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2023
Merged

[HttpFoundation] Fix bad return type in IpUtils::checkIp4() #49141

merged 1 commit into from
Jan 29, 2023

Conversation

tristankretzer
Copy link
Contributor
@tristankretzer tristankretzer commented Jan 27, 2023 •
edited
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets see below
License MIT
Doc PR -

filter_var returns the value if it passes the applied filters. This leads to IpUtils::checkIp4() returning the address part of the CIDR notation (instead of true which is expected) if it is a valid IPv4 address with subnet mask 0.

This change fixes this behaviour.

@carsonbot carsonbot added this to the 5.4 milestone Jan 27, 2023
@carsonbot carsonbot changed the title [httpFoundation] Fix bad return type in IpUtils::checkIp4() [HttpFoundation] Fix bad return type in IpUtils::checkIp4() Jan 27, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Thank you @tristankretzer.

@nicolas-grekas nicolas-grekas merged commit b8c7604 into symfony:5.4 Jan 29, 2023
@tristankretzer tristankretzer deleted the fix_ipUtils_checkIp4 branch January 29, 2023 14:11
This was referenced Feb 1, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@tristankretzer @carsonbot @nicolas-grekas @derrabus @xabbuh @chalasr
0