[Tests] Declare static data providers #48953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @alexandre-daubois, @OskarStark is already working on this topic and opened #48668. The issue was created 2 months ago #48281.
There is breaking changes #48668 (review). We are looking for the best solution that respects our BC policy. |
|
Alright thanks @GromNaN, I'll see if I can help there! 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As announced, PHPUnit 10 will be deprecating non static data providers. This is my take on changing framework's data providers to static ones. There are some providers left without static, the reason being they are using
$thisand they need a refactoring to be declared static.The process of adding static has been the following:
[StaticDataProviderClassMethodRector](https://github.com/rectorphp/rector-phpunit/blob/main/src/Rector/Class_/StaticDataProviderClassMethodRector.php)rule as described here: Add a rector turning data providers into static methods rectorphp/rector-phpunit#126$this)The PR is huge, the only thing that changed in the
statickeyword in front of data providers that allowed it.List of remaining non-static data providers, if needed for a meta-issue