8000 [Yaml] Minor: Update Inline parse phpdoc by alamirault · Pull Request #48932 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Yaml] Minor: Update Inline parse phpdoc #48932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Jan 10, 2023
Merged

[Yaml] Minor: Update Inline parse phpdoc #48932

merged 0 commits into from
Jan 10, 2023

Conversation

alamirault
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

I search everytime theses constants in this file

dump method has already good doc

symfony/src/Symfony/Component/Yaml/Inline.php

Line 99 in 21191d5

* @param int $flags A bit field of Yaml::DUMP_* constants to customize the dumped YAML string

@alamirault alamirault requested a review from xabbuh as a code owner January 9, 2023 19:36
@carsonbot carsonbot added this to the 5.4 milestone Jan 9, 2023
fabpot
fabpot requested changes Jan 10, 2023
View reviewed changes
@alamirault alamirault requested a review from fabpot January 10, 2023 18:25
@fabpot
Copy link
Member
fabpot commented Jan 10, 2023

Thank you @alamirault.

@fabpot fabpot closed this Jan 10, 2023
@fabpot fabpot force-pushed the hotfix/yaml-ineline-phpdoc branch from b154f45 to a535f00 Compare January 10, 2023 18:51
@fabpot fabpot merged commit a338736 into symfony:5.4 Jan 10, 2023
@alamirault alamirault deleted the hotfix/yaml-ineline-phpdoc branch January 10, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Yaml
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@alamirault @fabpot @xabbuh @maxbeckers @carsonbot
0