8000 [Translation] fix PhpAstExtractor also extracts messages if t() contains both unnamed and named arguments by gassan · Pull Request #48830 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translation] fix PhpAstExtractor also extracts messages if t() contains both unnamed and named arguments #48830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

[Translation] fix PhpAstExtractor also extracts messages if t() contains both unnamed and named arguments #48830

merged 1 commit into from
Jan 5, 2023

Conversation

gassan
Copy link
Contributor
@gassan gassan commented Dec 30, 2022

The case for $translator->trans('some message', domain: 'foo') was not covered by PhpAstExtractor.

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
License MIT

@gassan
[Translation] fix PhpAstExtractor also extracts messages from t()/tra…
96a020b 
…ns() that contains both unnamed and named arguments
@carsonbot carsonbot added this to the 6.2 milestone Dec 30, 2022
@fabpot
Copy link
Member
fabpot commented Jan 5, 2023

Thank you @gassan.

@fabpot fabpot merged commit 6f75529 into symfony:6.2 Jan 5, 2023
@gassan gassan deleted the mixed-named-unnamed branch January 5, 2023 09:27
@fabpot fabpot mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Translation
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@gassan @fabpot @carsonbot
0