[Validator] Deprecated the Size constraint in favor of MinCount and MaxCount #4851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1136,6 +1136,26 @@ | |||
| private $recursiveCollection; | |||
| ``` | |||
|
|
|||
| * The `Size` constraint was deprecated and will be removed in Symfony 2.1. You should | |||
fabpot
added a commit
that referenced
this pull request
Jul 11, 2012
Commits ------- 0be602d [Validator] Deprecated the Size constraint d661837 [Validator] Reverted the changes done to the Size constraint in 3a5e84f d84b689 [Validator] Added the constraints MinCount and MaxCount 1a732e4 [Validator] Removed the Range constraint as it duplicates functionality given in Min and Max Discussion ---------- [Validator] Deprecated the Size constraint in favor of MinCount and MaxCount Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - This PR cleans up with the current ambiguity between * Min * Max * MinLength * MaxLength * Range * Size in the following ways: * The Range constraint was removed again as it can be completely replaced by Min and Max. * The Size constraint was reverted to it's 2.0 feature set and deprecated. * The constraints MinCount and MaxCount were added to make up for the functionality that was added to Size.
|
I thought you would deprecate the other way round because it's more flexible. So e.g. Range in favor of Min and Max. Say my collection should contain excatly 8 elements so constraint MinCount(8) and MaxCount(8). |
|
Good points. I created a new PR that is referenced above. |
fabpot
added a commit
that referenced
this pull request
Jul 12, 2012
Commits ------- a92f80b [Validator] Added Length constraint and deprecated MinLength and MaxLength 83a3f75 [Validator] Deprecated the constraints Min and Max in favor of Range 0cdacee [Validator] Removed MinCount and MaxCount and replaced them by the constraint Count 741c147 [Validator] Renamed deprecated Size constraint to Range Discussion ---------- [Validator] Reintroduced Range constraint and created Count and Length constraints Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - After @Tobion's comment to #4851, this is the next try to streamline the constraints and reduce duplication of logic. The downside of the current MinLength/MaxLength and MinCount/MaxCount pairs is that they cannot output a fitting error message if a value should have an *exact* length/count. So this PR introduces * Range (formerly Size) to replace Min/Max * Count to replace MinCount/MaxCount * Length to replace MinLength/MaxLength Feedback is appreciated. --------------------------------------------------------------------------- by Tobion at 2012-07-11T20:40:08Z The `choice` constraint also cannot handle `min = max`. Or maybe we don't need these options on choice anymore as we can achieve the same with the new `count` constraint?! --------------------------------------------------------------------------- by beberlei at 2012-07-12T08:59:44Z Dude, nobody has time to fix the BC breaks you introduce :-) --------------------------------------------------------------------------- by TomAdam at 2012-07-12T12:38:49Z The changes to the `Size` validator yesterday broke my project, and I started rewriting to use `MaxLength / MinLength` validators today, until I spotted this. It would be good if this PR could have a reasonably high priority (whether or not it is accepted) as it will change how I fix my issues. I suspect a lot of people using the master branch will be in the same situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
This PR cleans up with the current ambiguity between
in the following ways: