8000 [HttpKernel] Fix using entities with the `#[Cache()]` attribute by HypeMC · Pull Request #48509 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Fix using entities with the #[Cache()] attribute #48509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

[HttpKernel] Fix using entities with the #[Cache()] attribute #48509

merged 1 commit into from
Dec 6, 2022

Conversation

@HypeMC
Copy link
Member
@HypeMC HypeMC commented Dec 6, 2022
Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48506
License MIT
Doc PR -

The #[Cache()] attribute is suppose to be a replacement for the SensioFrameworkExtraBundle @Cache annotation, but unlike the annotation, it doesn't work when entities are used in expressions. The reason for it is that the CacheAttributeListener is triggered by a kernel.controller event, while the EntityValueResolver is called afterwards:

symfony/src/Symfony/Component/HttpKernel/HttpKernel.php

Lines 150 to 159 in 97f0ce8

$event = new ControllerEvent($this, $controller, $request, $type);
$this->dispatcher->dispatch($event, KernelEvents::CONTROLLER);
$controller = $event->getController();
// controller arguments
$arguments = $this->argumentResolver->getArguments($request, $controller, $event->getControllerReflector());
$event = new ControllerArgumentsEvent($this, $event, $arguments, $request, $type);
$this->dispatcher->dispatch($event, KernelEvents::CONTROLLER_ARGUMENTS);
$controller = $event->getController();

This PR attempts to solve this problem by changing the event of the CacheAttributeListener to kernel.controller_arguments. Even though this has a BC break the listener was introduced in 6.2 so it might still be early enough to make this change? In any case, I don't have a better idea how to fix this, so I'm open to suggestions.

@carsonbot carsonbot added this to the 6.2 milestone Dec 6, 2022
@fabpot
Copy link
Member
fabpot commented Dec 6, 2022

Thank you @HypeMC.

@fabpot fabpot merged commit 7d45767 into symfony:6.2 Dec 6, 2022
@HypeMC HypeMC deleted the cache-attribute-fix branch December 6, 2022 17:07
@fabpot fabpot mentioned this pull request Dec 6, 2022
Merged
@HypeMC HypeMC mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

No one assigned

Labels

Bug HttpKernel Status: Reviewed

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

5 participants

@HypeMC @fabpot @nicolas-grekas @chalasr @carsonbot
0