[DomCrawler][FrameworkBundle] Add assertSelectorCount
#48424
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorCount.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorCount.php
Show resolved
Hide resolved
assertSelectorCount
|
Thank you for your reviews. I have updated my code and PR description. |
|
Thanks for approving! and thanks to @HeahDude for helping with my first contribution!!! |
|
deps=low failure is related. FrameworkBundle should bump the minimum version of DomCrawler in its composer.json file. |
40778c4 to
a257da8
Compare
|
ok so i have corrected the problem with low deps(and some extra white spaces). |
ab7e024 to
1d56613
Compare
|
Thank you @curlycarla2004. |
I was using the following test in my application:
After this PR:
What do you think about this?