8000 [Console] skip tests if the signal to be sent is not available by xabbuh · Pull Request #48329 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Console] skip tests if the signal to be sent is not available #48329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Nov 25, 2022
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh
Copy link
Member Author
xabbuh commented Nov 25, 2022

continues #48325

@fabpot
Copy link
Member
fabpot commented Nov 25, 2022

Thank you @xabbuh.

@fabpot fabpot merged commit 1daeece into symfony:5.4 Nov 25, 2022
@xabbuh xabbuh deleted the pr-45333 branch November 25, 2022 16:19
HeahDude added a commit to HeahDude/symfony that referenced this pull request Dec 17, 2022
HeahDude added a commit to HeahDude/symfony that referenced this pull request Dec 17, 2022
fabpot added a commit that referenced this pull request Dec 17, 2022
…ing #48329) (HeahDude)

This PR was merged into the 5.4 branch.

Discussion
----------

[Console] Fix a test when pcntl is not available (following #48329)

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ~
| License       | MIT
| Doc PR        | ~

The test is currently failing in AppVeyor (see https://ci.appveyor.com/project/fabpot/symfony/builds/45710392#L1577), the missing check seems present in tests above and below it.
Don't know what happened.

Commits
-------

db5ed1f [Console] Fix a test when pcntl is not available (following #48329)
derrabus added a commit that referenced this pull request Dec 20, 2022
* 5.4:
  Fix CS
  Compatibility with doctrine/annotations 2
  [Console] Fix a test when pcntl is not available (following #48329)
  [FrameworkBundle] fix: fix typo about help
derrabus added a commit that referenced this pull request Dec 20, 2022
* 6.0:
  Fix CS
  Compatibility with doctrine/annotations 2
  [Console] Fix a test when pcntl is not available (following #48329)
  [FrameworkBundle] fix: fix typo about help
derrabus added a commit that referenced this pull request Dec 20, 2022
* 6.1:
  Fix CS
  Compatibility with doctrine/annotations 2
  [Console] Fix a test when pcntl is not available (following #48329)
  [FrameworkBundle] fix: fix typo about help
derrabus added a commit that referenced this pull request Dec 20, 2022
* 6.2:
  Fix CS
  Compatibility with doctrine/annotations 2
  [Console] Fix a test when pcntl is not available (following #48329)
  [FrameworkBundle] fix: fix typo about help
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0