8000 [Notifier][SMSBiuras] Fix CS by OskarStark · Pull Request #48298 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier][SMSBiuras] Fix CS #48298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2022
Merged

[Notifier][SMSBiuras] Fix CS #48298

merged 1 commit into from
Nov 23, 2022

Conversation

OskarStark
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR

@OskarStark OskarStark requested a review from dunglas as a code owner November 23, 2022 11:54
@OskarStark OskarStark self-assigned this Nov 23, 2022
@carsonbot carsonbot added this to the 6.2 milestone Nov 23, 2022
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@OskarStark OskarStark changed the base branch from 6.2 to 5.4 November 23, 2022 11:54
@OskarStark OskarStark modified the milestones: 6.2, 5.4 Nov 23, 2022
@OskarStark OskarStark merged commit ddcf1ab into symfony:5.4 Nov 23, 2022
@carsonbot carsonbot changed the title Fix/fabbot [Notifier] Fix/fabbot Nov 23, 2022
@OskarStark OskarStark changed the title [Notifier] Fix/fabbot [Notifier][SMSBiuras] Fix CS Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas

Assignees

@OskarStark OskarStark

Labels
Notifier Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarStark @carsonbot
0